-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dubbo-serialization-avro into incubator-dubbo #3708 #3717
Conversation
@ralf0131 |
You can delete the line "xml version="1.0" encoding="UTF-8"" |
I tried to do this, but I can't solve it. |
You can run the UT locally and check the output to see what is the problem. For example: /home/travis/build/apache/incubator-dubbo/dubbo-serialization/dubbo-serialization-avro/target/rat.txt |
Codecov Report
@@ Coverage Diff @@
## master #3717 +/- ##
============================================
+ Coverage 63.62% 63.63% +0.01%
Complexity 71 71
============================================
Files 704 707 +3
Lines 31065 31129 +64
Branches 5037 5037
============================================
+ Hits 19764 19808 +44
- Misses 9032 9045 +13
- Partials 2269 2276 +7
Continue to review full report at Codecov.
|
Hi, While I am reviewing this pull request, I feel more people should come in and take a look. Please request @beiwei30 to review as well. |
...serialization-avro/src/main/java/org/apache/dubbo/common/serialize/avro/AvroObjectInput.java
Outdated
Show resolved
Hide resolved
...erialization-avro/src/main/java/org/apache/dubbo/common/serialize/avro/AvroObjectOutput.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rebase it with master? I guess some of the change has been made to master. For example, the license issues should be fixed already.
# Conflicts: # dubbo-bom/pom.xml # dubbo-serialization/dubbo-serialization-api/pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the pull request.
What is the purpose of the change
Merge dubbo-serialization-avro into incubator-dubbo #3708
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.