Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code style #3414

Closed
wants to merge 3 commits into from
Closed

code style #3414

wants to merge 3 commits into from

Conversation

dongYES
Copy link

@dongYES dongYES commented Feb 1, 2019

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3414 into 2.6.x will decrease coverage by 0.06%.
The diff coverage is 17.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.6.x    #3414      +/-   ##
============================================
- Coverage     47.28%   47.21%   -0.07%     
+ Complexity     4300     4294       -6     
============================================
  Files           554      554              
  Lines         24412    24416       +4     
  Branches       4321     4322       +1     
============================================
- Hits          11544    11529      -15     
- Misses        11077    11087      +10     
- Partials       1791     1800       +9
Impacted Files Coverage Δ Complexity Δ
...o/common/extension/support/ActivateComparator.java 17.5% <17.5%> (+6.38%) 3 <3> (ø) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 73.68% <0%> (-13.16%) 7% <0%> (-1%)
...ba/dubbo/remoting/transport/netty/NettyClient.java 74.13% <0%> (-8.63%) 12% <0%> (-1%)
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 77.77% <0%> (-5.56%) 5% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 54.21% <0%> (-3.62%) 13% <0%> (-2%)
...ba/dubbo/registry/multicast/MulticastRegistry.java 47.28% <0%> (-1.68%) 29% <0%> (ø)
...baba/dubbo/remoting/transport/mina/MinaClient.java 57.81% <0%> (-1.57%) 8% <0%> (-1%)
.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (+1.86%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f3094...b4cbb90. Read the comment docs.

@kun-song
Copy link
Contributor

kun-song commented Feb 1, 2019

It's same to #3412 ?

@beiwei30
Copy link
Member

beiwei30 commented Feb 1, 2019

same question as @satansk raised.

@beiwei30
Copy link
Member

beiwei30 commented Feb 1, 2019

looks like it's a dup, close it now.

@beiwei30 beiwei30 closed this Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants