-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-619] Fix consumer will generate wrong stackTrace #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… throws exception with empty stackTrace
Codecov Report
@@ Coverage Diff @@
## master #2956 +/- ##
=========================================
+ Coverage 63.94% 64.04% +0.1%
=========================================
Files 584 584
Lines 26056 26066 +10
Branches 4563 4565 +2
=========================================
+ Hits 16661 16695 +34
+ Misses 7212 7188 -24
Partials 2183 2183
Continue to review full report at Codecov.
|
zhaixiaoxiang
added a commit
to zhaixiaoxiang/incubator-dubbo
that referenced
this pull request
Mar 11, 2019
6 tasks
zhaixiaoxiang
added a commit
to zhaixiaoxiang/incubator-dubbo
that referenced
this pull request
Mar 14, 2019
zhaixiaoxiang
added a commit
to zhaixiaoxiang/incubator-dubbo
that referenced
this pull request
Mar 14, 2019
zhaixiaoxiang
added a commit
to zhaixiaoxiang/incubator-dubbo
that referenced
this pull request
Mar 14, 2019
carryxyh
pushed a commit
that referenced
this pull request
Apr 2, 2019
chickenlj
added a commit
to chickenlj/incubator-dubbo
that referenced
this pull request
May 23, 2019
6 tasks
cvictory
pushed a commit
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #619
Recur this bug in https://github.com/zhaixiaoxiang/dubbo-examples/tree/master/hessian-npe-demo
What is the purpose of the change
Fix Consumer will generate wrong stackTrace when provider throws exception with empty stackTrace. Please see https://www.yuque.com/fa902k/id5z6r/sr041v
Brief changelog
update:
org.apache.dubbo.rpc.RpcResult
add:
org.apache.dubbo.rpc.RpcResultTest
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.