Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-619] Fix consumer will generate wrong stackTrace #2956

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

zhaixiaoxiang
Copy link
Contributor

@zhaixiaoxiang zhaixiaoxiang commented Dec 13, 2018

Fix #619
Recur this bug in https://github.com/zhaixiaoxiang/dubbo-examples/tree/master/hessian-npe-demo

What is the purpose of the change

Fix Consumer will generate wrong stackTrace when provider throws exception with empty stackTrace. Please see https://www.yuque.com/fa902k/id5z6r/sr041v

Brief changelog

update:
org.apache.dubbo.rpc.RpcResult

add:
org.apache.dubbo.rpc.RpcResultTest

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2956 into master will increase coverage by 0.1%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2956     +/-   ##
=========================================
+ Coverage   63.94%   64.04%   +0.1%     
=========================================
  Files         584      584             
  Lines       26056    26066     +10     
  Branches     4563     4565      +2     
=========================================
+ Hits        16661    16695     +34     
+ Misses       7212     7188     -24     
  Partials     2183     2183
Impacted Files Coverage Δ
.../src/main/java/org/apache/dubbo/rpc/RpcResult.java 96.87% <90%> (-3.13%) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.02% <0%> (-0.35%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 68.45% <0%> (ø) ⬆️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (+1.86%) ⬆️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 66.12% <0%> (+3.22%) ⬆️
...e/dubbo/remoting/transport/netty/NettyChannel.java 62.35% <0%> (+4.7%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 84.61% <0%> (+5.12%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afcb9f2...7db3e8a. Read the comment docs.

@beiwei30 beiwei30 merged commit e4acdf7 into apache:master Dec 18, 2018
@zhaixiaoxiang zhaixiaoxiang deleted the issue-619 branch December 18, 2018 03:42
zhaixiaoxiang added a commit to zhaixiaoxiang/incubator-dubbo that referenced this pull request Mar 11, 2019
zhaixiaoxiang added a commit to zhaixiaoxiang/incubator-dubbo that referenced this pull request Mar 14, 2019
zhaixiaoxiang added a commit to zhaixiaoxiang/incubator-dubbo that referenced this pull request Mar 14, 2019
zhaixiaoxiang added a commit to zhaixiaoxiang/incubator-dubbo that referenced this pull request Mar 14, 2019
carryxyh pushed a commit that referenced this pull request Apr 2, 2019
chickenlj added a commit to chickenlj/incubator-dubbo that referenced this pull request May 23, 2019
cvictory pushed a commit that referenced this pull request May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

这个怎么搞,有人遇到过吗
3 participants