Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2560, use target/test-classes as the basedir #2563

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

diecui1202
Copy link

What is the purpose of the change

fix #2560, use target/test-classes as the basedir

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Sep 26, 2018

Codecov Report

Merging #2563 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2563      +/-   ##
============================================
- Coverage     54.98%   54.93%   -0.05%     
+ Complexity     5278     5276       -2     
============================================
  Files           573      573              
  Lines         25538    25538              
  Branches       4531     4531              
============================================
- Hits          14041    14030      -11     
- Misses         9396     9403       +7     
- Partials       2101     2105       +4
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 7% <0%> (-1%)
...onfig/spring/extension/SpringExtensionFactory.java 75.86% <0%> (-10.35%) 11% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.5% <0%> (-8.75%) 19% <0%> (-2%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 77.77% <0%> (-5.56%) 5% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 50.35% <0%> (-0.72%) 42% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 59.16% <0%> (+0.83%) 31% <0%> (+1%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 62.35% <0%> (+1.17%) 23% <0%> (+1%) ⬆️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 78.67% <0%> (+1.47%) 29% <0%> (ø) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (+4.16%) 3% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7ba29...f7afd5a. Read the comment docs.

@diecui1202 diecui1202 merged commit 733a376 into apache:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A empty directory dubbo-config/dubbo-config-spring/src/test/resources/work after package source tgz
2 participants