Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-2499]fix PojoUtil realize type convert not support subclasses of 'java.util.date' #2499 #2500

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

ningyu1
Copy link
Contributor

@ningyu1 ningyu1 commented Sep 13, 2018

What is the purpose of the change

fix PojoUtil realize type convert not support subclasses of 'java.util.date' #2499

Brief changelog

The type convert was modified to support the 'java.util.date' subclass

Verifying this change

org.apache.dubbo.common.utils.CompatibleTypeUtils.java
org.apache.dubbo.common.utils.PojoUtilsTest.java
org.apache.dubbo.common.utils.CompatibleTypeUtilsTest.java

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@diecui1202
Copy link

Looks good to me.

@diecui1202
Copy link

Need to merge back to 2.6.x?

@ningyu1
Copy link
Contributor Author

ningyu1 commented Sep 13, 2018

@diecui1202 Yes ,I will send a pr that fixes the 2.6.x branch.

@ningyu1
Copy link
Contributor Author

ningyu1 commented Sep 13, 2018

merge to 2.6.x #2502

@diecui1202 diecui1202 merged commit 8254e3d into apache:master Sep 14, 2018
@ningyu1 ningyu1 deleted the fix-pojo-type-convert branch September 14, 2018 01:35
@ningyu1 ningyu1 restored the fix-pojo-type-convert branch September 14, 2018 10:23
@ningyu1 ningyu1 deleted the fix-pojo-type-convert branch September 14, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants