2.6.x Spring Event & Bugfix #2256
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,23 +16,16 @@ | |
| */ | ||
| package com.alibaba.dubbo.config.spring; | ||
|
|
||
| import com.alibaba.dubbo.config.*; | ||
| import com.alibaba.dubbo.config.annotation.Service; | ||
| import com.alibaba.dubbo.config.spring.context.event.ServiceBeanExportedEvent; | ||
| import com.alibaba.dubbo.config.spring.extension.SpringExtensionFactory; | ||
| import org.springframework.aop.support.AopUtils; | ||
| import org.springframework.beans.factory.BeanFactoryUtils; | ||
| import org.springframework.beans.factory.BeanNameAware; | ||
| import org.springframework.beans.factory.DisposableBean; | ||
| import org.springframework.beans.factory.InitializingBean; | ||
| import org.springframework.context.*; | ||
|
There was a problem hiding this comment. make sure not add import * , same as @diecui1202 said. |
||
| import org.springframework.context.event.ContextRefreshedEvent; | ||
| import org.springframework.context.support.AbstractApplicationContext; | ||
|
|
||
|
|
@@ -46,7 +39,9 @@ | |
| * | ||
| * @export | ||
| */ | ||
| public class ServiceBean<T> extends ServiceConfig<T> implements InitializingBean, DisposableBean, | ||
| ApplicationContextAware, ApplicationListener<ContextRefreshedEvent>, BeanNameAware, | ||
| ApplicationEventPublisherAware { | ||
|
|
||
| private static final long serialVersionUID = 213195494150089726L; | ||
|
|
||
|
|
@@ -60,6 +55,8 @@ public class ServiceBean<T> extends ServiceConfig<T> implements InitializingBean | |
|
|
||
| private transient boolean supportedApplicationListener; | ||
|
|
||
| private ApplicationEventPublisher applicationEventPublisher; | ||
|
|
||
| public ServiceBean() { | ||
| super(); | ||
| this.service = null; | ||
|
|
@@ -265,6 +262,34 @@ && getInterface() != null && getInterface().length() > 0 | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * Get the name of {@link ServiceBean} | ||
| * | ||
| * @return {@link ServiceBean}'s name | ||
| * @since 2.6.4 | ||
| */ | ||
| public String getBeanName() { | ||
| return this.beanName; | ||
| } | ||
|
|
||
| /** | ||
| * @since 2.6.4 | ||
| */ | ||
| @Override | ||
| public void export() { | ||
| super.export(); | ||
| // Publish ServiceBeanExportedEvent | ||
| publishExportEvent(); | ||
| } | ||
|
|
||
| /** | ||
| * @since 2.6.4 | ||
| */ | ||
| private void publishExportEvent() { | ||
| ServiceBeanExportedEvent exportEvent = new ServiceBeanExportedEvent(this); | ||
| applicationEventPublisher.publishEvent(exportEvent); | ||
| } | ||
|
|
||
| @Override | ||
| public void destroy() throws Exception { | ||
| // This will only be called for singleton scope bean, and expected to be called by spring shutdown hook when BeanFactory/ApplicationContext destroys. | ||
|
|
@@ -280,4 +305,13 @@ protected Class getServiceClass(T ref) { | |
| } | ||
| return super.getServiceClass(ref); | ||
| } | ||
|
|
||
| /** | ||
| * @param applicationEventPublisher | ||
| * @since 2.6.4 | ||
| */ | ||
| @Override | ||
| public void setApplicationEventPublisher(ApplicationEventPublisher applicationEventPublisher) { | ||
| this.applicationEventPublisher = applicationEventPublisher; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure not add import *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it requires change IDEA Template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code style template: https://github.com/apache/incubator-dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml