Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix httpStatusToGrpcStatus always return 13 #14563

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

xingcici
Copy link
Contributor

@xingcici xingcici commented Aug 20, 2024

What is the purpose of the change

fix httpStatusToGrpcStatus always return 13
issus #14498

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@xingcici xingcici changed the title fix: fix httpStatusToGrpcStatus always return 13 https://github.com/a… fix: fix httpStatusToGrpcStatus always return 13 Aug 20, 2024
@oxsean
Copy link
Collaborator

oxsean commented Aug 20, 2024

I will fix it in PR: #14513

Copy link

sonarcloud bot commented Aug 20, 2024

@AlbumenJ AlbumenJ merged commit 32336db into apache:3.3 Aug 21, 2024
19 checks passed
@xingcici xingcici deleted the fix/http_status_to_grpc_status branch August 21, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants