Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-#895]Support implicit delivery of attachments from provider to consumer #1094

Closed
wants to merge 3 commits into from

Conversation

hsrong
Copy link

@hsrong hsrong commented Dec 22, 2017

What is the purpose of the change

支持隐式参数的回传(从服务端传到消费端),#889#895#889#895 是同一个问题

Brief changelog

  1. 增加两种响应标识RESPONSE_ATTACHMENTS_NO_EXIST、RESPONSE_ATTACHMENTS_EXIST
  2. 编码时,增加了对Result的Attachments的处理代码
  3. 解码时,增加了对两个响应标识(RESPONSE_ATTACHMENTS_NO_EXIST、RESPONSE_ATTACHMENTS_EXIST)的处理代码
  4. 增加了ImplicitParamReturnBackTest测试代码

Verifying this change

ImplicitParamReturnBackTest测试通过,控制台打印:
set Attachments in ProviderFilter: SOME_ATTACHMENT_KEY=the value come from ProviderFilter
get Attachments in ConsumerFilter: SOME_ATTACHMENT_KEY=the value come from ProviderFilter
并且没有报错

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2017

CLA assistant check
All committers have signed the CLA.

@chickenlj chickenlj changed the title [Dubbo-#895]支持隐式参数的回传(从服务端传到消费端) [Dubbo-#895]Support implicit delivery of attachments from provider to consumer Jan 4, 2018
@chickenlj
Copy link
Contributor

chickenlj commented Jan 4, 2018

I think there will be a compatibility problem when projects using different dubbo version calling each other.

@chickenlj
Copy link
Contributor

This feature should be supported, we can figure out a better solution.

@chickenlj chickenlj closed this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants