Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Survey] Is it necessary to continue to maintain zkclient in dubbo project? #3569

Closed
cvictory opened this issue Feb 26, 2019 · 7 comments
Closed
Milestone

Comments

@cvictory
Copy link
Contributor

There are two zookeeper implements that are curator and zkclient.

ZkClient github: https://github.com/sgroschupf/zkclient/tree/master/src/main/java/org/I0Itec/zkclient .
And the repository is not updated frequently.

So if you think we should continue to keep zkClient in dubbo project , please reply -1 and give us reason.

[+1] : remove.
[-1] :Keep. And give us some reason or what you encounter.

@ralf0131
Copy link
Contributor

+1 to remove zkclient

@chickenlj
Copy link
Contributor

I think we can rely on curator directly as it has emerged as the facto standard of zk client tools.
Maintaining the zk client SPI requires much effort from us but with only less gain.

@mercyblitz
Copy link
Contributor

+1 Agreed to delete

@CrazyHZM
Copy link
Member

+1 remove

@kezhenxu94
Copy link
Member

+1 to remove

@mercyblitz mercyblitz modified the milestones: 2.6.7, some day Mar 4, 2019
@cvictory
Copy link
Contributor Author

cvictory commented Mar 5, 2019 via email

@cvictory
Copy link
Contributor Author

cvictory commented Mar 5, 2019

I think we can rely on curator directly as it has emerged as the facto standard of zk client tools.
Maintaining the zk client SPI requires much effort from us but with only less gain.

I think we will remove zkclient firstly, but not to depend curator directly. This change is too big.
Maybe we should disscuss it in a new issue at community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants