Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.apache.dubbo.common.utils.ConfigUtils#loadProperties(java.lang.String, boolean, boolean) miss windows scene #2557

Closed
SuperDubbo opened this issue Sep 25, 2018 · 3 comments · Fixed by #2562
Labels
help wanted Everything needs help from contributors

Comments

@SuperDubbo
Copy link
Contributor

Environment

  • Dubbo version: dubbo-2.6.4
  • Operating System version: windows 10
  • Java version: JDK1.8

When run the testcase(com.alibaba.dubbo.config.AbstractInterfaceConfigTest#checkApplication1) in windows environment,It will be wrong.

So It should add scene judgement in windows environment(org.apache.dubbo.common.utils.ConfigUtils#loadProperties(java.lang.String, boolean, boolean),Line 220).

if (fileName.startsWith("/")) {

change to

if (fileName.startsWith("/")||fileName.matches("^[A-z]:\\\\\\S+$")) {

the testcase (com.alibaba.dubbo.config.AbstractInterfaceConfigTest#checkApplication1) will go well.

@ralf0131
Copy link
Contributor

Hi, thanks for reporting, would you please send a pull request?

@ralf0131 ralf0131 added the help wanted Everything needs help from contributors label Sep 25, 2018
@ralf0131
Copy link
Contributor

Hi, please refer to this: https://github.com/apache/incubator-dubbo/blob/master/CONTRIBUTING.md

You need to fork Dubbo first.

@SuperDubbo
Copy link
Contributor Author

I have pull a request,Thank You @ralf0131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Everything needs help from contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants