Add: anyhost key judgment #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed the |
zouyx
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Based on https://github.com/apache/dubbo-go/blob/master/contributing.md to change the title
AlexStocks
reviewed
Jun 24, 2020
Thanks. I will pay attention to the rule in next PR. |
zouyx
previously approved these changes
Jun 25, 2020
zouyx
reviewed
Jul 1, 2020
chickenlj
requested changes
Jul 1, 2020
|
Sorry for my lateness. Change request done. |
zouyx
approved these changes
Jul 3, 2020
chickenlj
approved these changes
Jul 3, 2020
AlexStocks
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add anyhost judgment in ToConfigurators in registry/base_configuration_listener.go, which is used to improve code quality by removing 'TODO' comment
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: