Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem of rest protocol PR #352 #402

Merged
merged 7 commits into from
Mar 14, 2020
Merged

Conversation

Patrick0308
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #402 into feature/rest will increase coverage by 0.04%.
The diff coverage is 68.75%.

Impacted file tree graph

@@               Coverage Diff                @@
##           feature/rest     #402      +/-   ##
================================================
+ Coverage         67.48%   67.53%   +0.04%     
================================================
  Files               170      170              
  Lines              8591     8596       +5     
================================================
+ Hits               5798     5805       +7     
+ Misses             2252     2247       -5     
- Partials            541      544       +3     
Impacted Files Coverage Δ
common/extension/rest_client.go 0.00% <0.00%> (ø)
common/extension/rest_config_reader.go 0.00% <0.00%> (ø)
common/extension/rest_server.go 0.00% <0.00%> (ø)
...config_reader/reader_impl/default_config_reader.go 69.23% <63.63%> (ø)
protocol/rest/rest_protocol.go 75.34% <75.00%> (-4.94%) ⬇️
config/rest_config_loader.go 77.10% <76.00%> (ø)
config/config_loader.go 63.71% <100.00%> (+1.33%) ⬆️
protocol/rest/rest_invoker.go 72.54% <100.00%> (ø)
config_center/nacos/client.go 57.26% <0.00%> (+1.70%) ⬆️
config_center/nacos/facade.go 62.50% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c55d99...e9fc1f8. Read the comment docs.

@flycash flycash merged commit dafc2f4 into apache:feature/rest Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants