-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: ExecuteLimit Support #246
Feature: ExecuteLimit Support #246
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #246 +/- ##
===========================================
+ Coverage 64.97% 65.06% +0.08%
===========================================
Files 104 105 +1
Lines 6744 6792 +48
===========================================
+ Hits 4382 4419 +37
- Misses 1920 1928 +8
- Partials 442 445 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Implement the ExecuteLimitFilter, which used to limit the concurrent requests.
Both the service-level and method-level are supports. But if the user doesn't configure the
execute.limit
in their service or the value of that is negative, the filter will do nothing.Which issue(s) this PR fixes:
Fixes #245
Special notes for your reviewer:
The interface RejectedExecutionHandler is used to support this filter, so it has been removed to filter/common;
Does this PR introduce a user-facing change?: