Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY #1078

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

tweitjss
Copy link

@tweitjss tweitjss commented Mar 9, 2021

What this PR does:

fix RPCInvocation.ServiceKey use INTERFACE_KEY which is different from java

Which issue(s) this PR fixes:

Fixes #1077

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov-io
Copy link

Codecov Report

Merging #1078 (bc375f7) into master (9b80e89) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1078      +/-   ##
==========================================
- Coverage   59.57%   59.43%   -0.14%     
==========================================
  Files         268      268              
  Lines       13367    13367              
==========================================
- Hits         7963     7945      -18     
- Misses       4418     4435      +17     
- Partials      986      987       +1     
Impacted Files Coverage Δ
remoting/kubernetes/watch.go 72.52% <0.00%> (-6.60%) ⬇️
remoting/kubernetes/registry_controller.go 46.12% <0.00%> (-5.31%) ⬇️
remoting/kubernetes/client.go 72.05% <0.00%> (-2.95%) ⬇️
remoting/kubernetes/listener.go 50.52% <0.00%> (ø)
cluster/cluster_impl/base_cluster_invoker.go 61.62% <0.00%> (+3.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b80e89...bc375f7. Read the comment docs.

@AlexStocks AlexStocks requested a review from cvictory March 9, 2021 08:03
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you help to add a test case for this change?

@zouyx zouyx added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Mar 9, 2021
@zouyx
Copy link
Member

zouyx commented Mar 9, 2021

What this PR does:

fix RPCInvocation.ServiceKey use INTERFACE_KEY which is different from java

Which issue(s) this PR fixes:

Fixes #1077

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@tweitjss Thanks for you contribution.

@AlexStocks
Copy link
Contributor

firstly, pls move ur target branch from master to 3.0. sencondly, pls add an ut.

@AlexStocks AlexStocks changed the base branch from master to 1.5 March 11, 2021 05:09
@AlexStocks AlexStocks added this to the v1.5.6-rc2 milestone Mar 11, 2021
@AlexStocks AlexStocks merged commit 99d3d4f into apache:1.5 Mar 15, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using different attachmentKey with java server when buiding ServiceKey
6 participants