-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY #1078
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
- Coverage 59.57% 59.43% -0.14%
==========================================
Files 268 268
Lines 13367 13367
==========================================
- Hits 7963 7945 -18
- Misses 4418 4435 +17
- Partials 986 987 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you help to add a test case for this change?
firstly, pls move ur target branch from master to 3.0. sencondly, pls add an ut. |
fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
What this PR does:
fix RPCInvocation.ServiceKey use INTERFACE_KEY which is different from java
Which issue(s) this PR fixes:
Fixes #1077
Special notes for your reviewer:
Does this PR introduce a user-facing change?: