Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just one character is enough for the name of the receiver. #1276

Closed
AlexStocks opened this issue Jun 25, 2021 · 4 comments
Closed

Just one character is enough for the name of the receiver. #1276

AlexStocks opened this issue Jun 25, 2021 · 4 comments
Assignees
@LaurenceLiZhixin
Labels
good first issue Good for newcomers

Comments

@AlexStocks
Copy link
Contributor

What would you like to be added:

I know give a name of a var is a very difficult problem in computer science. However, just one character for a receiver name should be enough.

the shorter receiver name of AttachmentMatchJudger in router/v3router/judger/attachment_match_judger.go should not be 'amj'. The same problem exists in the following items too.

 router/v3router/judger/bool_match_judger.go BoolMathJudger
 router/v3router/judger/double_match_judger.go DoubleMatchJudger
 router/v3router/judger/double_range_match_judger.go DoubleRangeMatchJudger
 router/v3router/judger/list_double_match_judger.go ListDoubleMatchJudger
 router/v3router/judger/list_string_match_judger.go ListStringMatchJudger
 router/v3router/judger/method_match_judger.go MethodMatchJudger
 router/v3router/judger/string_match_judger.go StringMatchJudger
 router/v3router/dubbo_rule.go DubboRouterRule
@AlexStocks
Copy link
Contributor Author

cc @LaurenceLiZhixin

@LaurenceLiZhixin LaurenceLiZhixin self-assigned this Jun 25, 2021
@LaurenceLiZhixin LaurenceLiZhixin added the good first issue Good for newcomers label Aug 16, 2021
@LaurenceLiZhixin
Copy link
Contributor

@Mulavar Do you think it's necessary to change name?

@Mulavar
Copy link
Member

Mulavar commented Nov 3, 2021

It‘s a good question about how to assign the name of a variable better.In my opnion, I think there's no difference between a and amj when we use them for a receiver name, because both they lost the meaning of the receiver. A unified standard is enough.

@AlexStocks
Copy link
Contributor Author

Just one char is enough for a receiver name as Go programming rule.

Mulavar pushed a commit to Mulavar/dubbo-go that referenced this issue Nov 5, 2021
[apache#1276]modify the name of the receiver to a single character
d75f0fc
AlexStocks pushed a commit that referenced this issue Nov 5, 2021
@Mulavar
[#1276]modify the name of the receiver to a single character (#1561)
35d27b4 
Co-authored-by: dongjianhui03 <[email protected]>
binbin0325 pushed a commit to binbin0325/dubbo-go that referenced this issue Nov 6, 2021
@Mulavar @binbin0325
[apache#1276]modify the name of the receiver to a single character (a…
e7d4e6b 
…pache#1561)

Co-authored-by: dongjianhui03 <[email protected]>
AlexStocks added a commit that referenced this issue Nov 22, 2021
@LaurenceLiZhixin @dependabot
@AlexStocks @Mulavar @justxuewei @PhilYue @binbin0325 @zhaoyunxing92 @XiaoWeiKIN @wongoo
Merge 3.0 to master (#1606)
5cd1a52 
* build(deps): bump github.com/hashicorp/vault/sdk from 0.2.1 to 0.3.0 (#1552)

Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.2.1 to 0.3.0.
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md)
- [Commits](hashicorp/vault@sdk/v0.2.1...v0.3.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/vault/sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* delete useless codes (#1551)

* Update CHANGELOG.md

* [#1559]: adjust the startup process of the configuration center (#1560)

* [#1559]:
1. fix the startup process of the configuration center(remove error log)
2. refactor zk registry listener

* delete redundant dynamic configuration center cache

Co-authored-by: dongjianhui03 <[email protected]>

* [#1276]modify the name of the receiver to a single character (#1561)

Co-authored-by: dongjianhui03 <[email protected]>

* style(common): rename constants in camel-case style (#1563)

* style(common): rename constants in camel-case style

* style(common): rename Ttl to TTL

* fix: #1558: Set root config to global ptr in Init() function. (#1564)

* fix: #1558

* fix: change the api to start the app by config-api

* fix: in the Consumer service, the Reference config property ‘check’ use the Consumer config when omitted

* Triple upgrade to grpc (#1566)

* fix: init triple grpc

* fix: delete replace

* Fix: upgrade triple grpc

* Fix: remove unused file

* Fix decrease grpc go version to 1.14

* Fix: add server side serialization

* register not use metadata configuration.

* build(deps): bump github.com/go-resty/resty/v2 from 2.3.0 to 2.7.0 (#1579)

Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.3.0 to 2.7.0.
- [Release notes](https://github.com/go-resty/resty/releases)
- [Commits](go-resty/resty@v2.3.0...v2.7.0)

---
updated-dependencies:
- dependency-name: github.com/go-resty/resty/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump google.golang.org/grpc from 1.41.0 to 1.42.0 (#1578)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.41.0...v1.42.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/knadh/koanf from 1.3.0 to 1.3.2 (#1577)

Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.3.0 to 1.3.2.
- [Release notes](https://github.com/knadh/koanf/releases)
- [Commits](knadh/koanf@v1.3.0...v1.3.2)

---
updated-dependencies:
- dependency-name: github.com/knadh/koanf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: registry param

* fix: fix ns and group

* fix: integrate test

* Fix: integrate test

* fix: url fmt

* fix: nacos servicediscovery group

* Fix: enhance zk

* start application (#1571)

Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: lizhixin.lzx <[email protected]>
Co-authored-by: LaurenceLiZhixin <[email protected]>

* graceful shutdwon filter (#1585)

Co-authored-by: wangxiaowei14227 <[email protected]>

* Fix: some bugs and features for 3.0 (#1586)

* fix: some bugs

* Fix: remove file\k8s registry, k8s remote

* refactor listenDirEvent
1. remove CLEAR label;
2. remove register/unregister logic for watch children;
3. reorder the zk dynamic configuration code
4. adapt the gost

* hessian encode attachments return error (#1588)

* upgrade gost dependency version

* upgrade hessian to v1.9.5 (#1595)

* build(deps): bump k8s.io/apimachinery from 0.16.9 to 0.22.4 (#1600)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.16.9 to 0.22.4.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.16.9...v0.22.4)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ftr: triple tracing (#1596)

* ftr: triple tracing

* fix: if-else to switch

* [fix #1590] filter single instance (#1591)

* filter single instance

* filter single instance

Co-authored-by: wangxiaowei14227 <[email protected]>

* Ftr/triple reflect support (#1603)

* ftr: triple-reflection

* fix: comment and var name

* Fix: comment typo

* Fix: official website

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: Mulavar <[email protected]>
Co-authored-by: dongjianhui03 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: PhilYue <[email protected]>
Co-authored-by: lizhixin.lzx <[email protected]>
Co-authored-by: sanxun0325 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: zhaoyunxing <[email protected]>
Co-authored-by: wangxw <[email protected]>
Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: 望哥 <[email protected]>
AlexStocks added a commit that referenced this issue Dec 1, 2021
@chuntaojun @LaurenceLiZhixin
@dependabot @AlexStocks @Mulavar @justxuewei @PhilYue @binbin0325 @zhaoyunxing92 @XiaoWeiKIN @wongoo
[ISSUE #1601] polarismesh registry center (#1620)
a8fba70 
* feat: try to support dubbo

* Merge 3.0 to master (#1606)

* build(deps): bump github.com/hashicorp/vault/sdk from 0.2.1 to 0.3.0 (#1552)

Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.2.1 to 0.3.0.
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md)
- [Commits](hashicorp/vault@sdk/v0.2.1...v0.3.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/vault/sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* delete useless codes (#1551)

* Update CHANGELOG.md

* [#1559]: adjust the startup process of the configuration center (#1560)

* [#1559]:
1. fix the startup process of the configuration center(remove error log)
2. refactor zk registry listener

* delete redundant dynamic configuration center cache

Co-authored-by: dongjianhui03 <[email protected]>

* [#1276]modify the name of the receiver to a single character (#1561)

Co-authored-by: dongjianhui03 <[email protected]>

* style(common): rename constants in camel-case style (#1563)

* style(common): rename constants in camel-case style

* style(common): rename Ttl to TTL

* fix: #1558: Set root config to global ptr in Init() function. (#1564)

* fix: #1558

* fix: change the api to start the app by config-api

* fix: in the Consumer service, the Reference config property ‘check’ use the Consumer config when omitted

* Triple upgrade to grpc (#1566)

* fix: init triple grpc

* fix: delete replace

* Fix: upgrade triple grpc

* Fix: remove unused file

* Fix decrease grpc go version to 1.14

* Fix: add server side serialization

* register not use metadata configuration.

* build(deps): bump github.com/go-resty/resty/v2 from 2.3.0 to 2.7.0 (#1579)

Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.3.0 to 2.7.0.
- [Release notes](https://github.com/go-resty/resty/releases)
- [Commits](go-resty/resty@v2.3.0...v2.7.0)

---
updated-dependencies:
- dependency-name: github.com/go-resty/resty/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump google.golang.org/grpc from 1.41.0 to 1.42.0 (#1578)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.41.0...v1.42.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/knadh/koanf from 1.3.0 to 1.3.2 (#1577)

Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.3.0 to 1.3.2.
- [Release notes](https://github.com/knadh/koanf/releases)
- [Commits](knadh/koanf@v1.3.0...v1.3.2)

---
updated-dependencies:
- dependency-name: github.com/knadh/koanf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: registry param

* fix: fix ns and group

* fix: integrate test

* Fix: integrate test

* fix: url fmt

* fix: nacos servicediscovery group

* Fix: enhance zk

* start application (#1571)

Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: lizhixin.lzx <[email protected]>
Co-authored-by: LaurenceLiZhixin <[email protected]>

* graceful shutdwon filter (#1585)

Co-authored-by: wangxiaowei14227 <[email protected]>

* Fix: some bugs and features for 3.0 (#1586)

* fix: some bugs

* Fix: remove file\k8s registry, k8s remote

* refactor listenDirEvent
1. remove CLEAR label;
2. remove register/unregister logic for watch children;
3. reorder the zk dynamic configuration code
4. adapt the gost

* hessian encode attachments return error (#1588)

* upgrade gost dependency version

* upgrade hessian to v1.9.5 (#1595)

* build(deps): bump k8s.io/apimachinery from 0.16.9 to 0.22.4 (#1600)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.16.9 to 0.22.4.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.16.9...v0.22.4)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ftr: triple tracing (#1596)

* ftr: triple tracing

* fix: if-else to switch

* [fix #1590] filter single instance (#1591)

* filter single instance

* filter single instance

Co-authored-by: wangxiaowei14227 <[email protected]>

* Ftr/triple reflect support (#1603)

* ftr: triple-reflection

* fix: comment and var name

* Fix: comment typo

* Fix: official website

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: Mulavar <[email protected]>
Co-authored-by: dongjianhui03 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: PhilYue <[email protected]>
Co-authored-by: lizhixin.lzx <[email protected]>
Co-authored-by: sanxun0325 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: zhaoyunxing <[email protected]>
Co-authored-by: wangxw <[email protected]>
Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: 望哥 <[email protected]>

* feat: support polaris

* feat: support polarismesh registry

* fix: fix cr issue

* chore: run go mod tidy to fix ci-error

* refactor: change polaris::ConsumerAPI.GetInstances => GetAllInstances

* fix github action scan error

* fix: fix go fmt error

* fix: import formatter

* fix: fix cr issue

* fix: fix code-style check error

* fix: fix cr issue

* fix: fix maybe nil error

* fix: fix lose event bug

* style: fix code style

Co-authored-by: springliao <[email protected]>
Co-authored-by: Laurence <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: Mulavar <[email protected]>
Co-authored-by: dongjianhui03 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: PhilYue <[email protected]>
Co-authored-by: lizhixin.lzx <[email protected]>
Co-authored-by: sanxun0325 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: zhaoyunxing <[email protected]>
Co-authored-by: wangxw <[email protected]>
Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: 望哥 <[email protected]>
Co-authored-by: LaurenceLiZhixin <[email protected]>
AlexStocks added a commit that referenced this issue Dec 21, 2021
@marsmay @LaurenceLiZhixin
@dependabot @AlexStocks @Mulavar @justxuewei @PhilYue @binbin0325 @zhaoyunxing92 @XiaoWeiKIN @wongoo @luky116
add OPay logo to user list (#1684)
3bfa678 
* Merge 3.0 to master (#1606)

* build(deps): bump github.com/hashicorp/vault/sdk from 0.2.1 to 0.3.0 (#1552)

Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.2.1 to 0.3.0.
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md)
- [Commits](hashicorp/vault@sdk/v0.2.1...v0.3.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/vault/sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* delete useless codes (#1551)

* Update CHANGELOG.md

* [#1559]: adjust the startup process of the configuration center (#1560)

* [#1559]:
1. fix the startup process of the configuration center(remove error log)
2. refactor zk registry listener

* delete redundant dynamic configuration center cache

Co-authored-by: dongjianhui03 <[email protected]>

* [#1276]modify the name of the receiver to a single character (#1561)

Co-authored-by: dongjianhui03 <[email protected]>

* style(common): rename constants in camel-case style (#1563)

* style(common): rename constants in camel-case style

* style(common): rename Ttl to TTL

* fix: #1558: Set root config to global ptr in Init() function. (#1564)

* fix: #1558

* fix: change the api to start the app by config-api

* fix: in the Consumer service, the Reference config property ‘check’ use the Consumer config when omitted

* Triple upgrade to grpc (#1566)

* fix: init triple grpc

* fix: delete replace

* Fix: upgrade triple grpc

* Fix: remove unused file

* Fix decrease grpc go version to 1.14

* Fix: add server side serialization

* register not use metadata configuration.

* build(deps): bump github.com/go-resty/resty/v2 from 2.3.0 to 2.7.0 (#1579)

Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.3.0 to 2.7.0.
- [Release notes](https://github.com/go-resty/resty/releases)
- [Commits](go-resty/resty@v2.3.0...v2.7.0)

---
updated-dependencies:
- dependency-name: github.com/go-resty/resty/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump google.golang.org/grpc from 1.41.0 to 1.42.0 (#1578)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.41.0...v1.42.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/knadh/koanf from 1.3.0 to 1.3.2 (#1577)

Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.3.0 to 1.3.2.
- [Release notes](https://github.com/knadh/koanf/releases)
- [Commits](knadh/koanf@v1.3.0...v1.3.2)

---
updated-dependencies:
- dependency-name: github.com/knadh/koanf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: registry param

* fix: fix ns and group

* fix: integrate test

* Fix: integrate test

* fix: url fmt

* fix: nacos servicediscovery group

* Fix: enhance zk

* start application (#1571)

Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: lizhixin.lzx <[email protected]>
Co-authored-by: LaurenceLiZhixin <[email protected]>

* graceful shutdwon filter (#1585)

Co-authored-by: wangxiaowei14227 <[email protected]>

* Fix: some bugs and features for 3.0 (#1586)

* fix: some bugs

* Fix: remove file\k8s registry, k8s remote

* refactor listenDirEvent
1. remove CLEAR label;
2. remove register/unregister logic for watch children;
3. reorder the zk dynamic configuration code
4. adapt the gost

* hessian encode attachments return error (#1588)

* upgrade gost dependency version

* upgrade hessian to v1.9.5 (#1595)

* build(deps): bump k8s.io/apimachinery from 0.16.9 to 0.22.4 (#1600)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.16.9 to 0.22.4.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.16.9...v0.22.4)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ftr: triple tracing (#1596)

* ftr: triple tracing

* fix: if-else to switch

* [fix #1590] filter single instance (#1591)

* filter single instance

* filter single instance

Co-authored-by: wangxiaowei14227 <[email protected]>

* Ftr/triple reflect support (#1603)

* ftr: triple-reflection

* fix: comment and var name

* Fix: comment typo

* Fix: official website

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: Mulavar <[email protected]>
Co-authored-by: dongjianhui03 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: PhilYue <[email protected]>
Co-authored-by: lizhixin.lzx <[email protected]>
Co-authored-by: sanxun0325 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: zhaoyunxing <[email protected]>
Co-authored-by: wangxw <[email protected]>
Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: 望哥 <[email protected]>

* fix unexported bug (#1634)

* Revert "fix unexported bug (#1634)" (#1635)

This reverts commit 5604ba5.

* add OPay logo to user list

Co-authored-by: Laurence <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: Mulavar <[email protected]>
Co-authored-by: dongjianhui03 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: PhilYue <[email protected]>
Co-authored-by: lizhixin.lzx <[email protected]>
Co-authored-by: sanxun0325 <[email protected]>
Co-authored-by: Xuewei Niu <[email protected]>
Co-authored-by: zhaoyunxing <[email protected]>
Co-authored-by: wangxw <[email protected]>
Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: 望哥 <[email protected]>
Co-authored-by: 刘月财 <[email protected]>
Co-authored-by: AlexStocks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LaurenceLiZhixin LaurenceLiZhixin

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexStocks @Mulavar @LaurenceLiZhixin