Fix: spring cloud error and refactor event callback #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm all output file when make clean
2. add zookeeper root path config
Codecov Report
@@ Coverage Diff @@
## develop-0.5.0 #367 +/- ##
==============================================
Coverage 39.66% 39.66%
==============================================
Files 52 52
Lines 3061 3061
==============================================
Hits 1214 1214
Misses 1717 1717
Partials 130 130 Continue to review full report at Codecov.
|
PhilYue
changed the title
PhilYue
changed the title
PhilYue
force-pushed
the
fix/sczkerror
branch
from
e326fc7 to
1cb658f
Compare
mark4z
approved these changes
Feb 23, 2022
| for _, instance := range discovery.getServiceMap()[sn] { | ||
| discovery.delServiceInstance(instance) | ||
| } | ||
| if !contains(fetchChildren, sn) { |
|
|
||
| for _, serviceName := range fetchChildren { | ||
| serviceNodePath := strings.Join([]string{z.servicesPath, serviceName}, constant.PathSlash) | ||
| instances := serviceMap[serviceName] | ||
| if instances == nil || len(instances) == 0 { | ||
| z.svcListeners.RemoveListener(serviceNodePath) |
AlexStocks
approved these changes
Feb 24, 2022
ztelur
approved these changes
Feb 26, 2022
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
* rm all output file when make clean * 1. fix error log and event callback 2. add zookeeper root path config * fmt... * close the service instance listener when it not working and after retry * fix the CI * clean Co-authored-by: Randy <[email protected]> Co-authored-by: Xin.Zh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: