Additional fix for columns with cardinality 0 #88
Conversation
| @@ -33,6 +33,7 @@ | |||
|
|
|||
| import java.io.File; | |||
| import java.util.Arrays; | |||
| import java.util.List; | |||
There was a problem hiding this comment.
Do you need to import java.util.List when you are already using Guava?
There was a problem hiding this comment.
ya srsly Gian, what's up with that?
There was a problem hiding this comment.
Joshu began the study of Zen when he was sixty years old and continued until he was eighty, when he realized Zen.
He taught from the age of eighty until he was one hundred and twenty.
A student once asked him: "If I haven't anything in my mind, what shall I do?"
Joshu replied: "Throw it out."
"But if I haven't anything, how can I throw it out?" continued the questioner.
"Well," said Joshu, "then carry it out."
There was a problem hiding this comment.
Joshu is the senior engineer giving advice to the junior engineer. The jr engineer is all like 'wtf did Joshu just say' and Joshu is all like 'so is what I asked for coded up yet?'.
There was a problem hiding this comment.
That java.util.List import is stray. The code isn't using List. I accepted the merged and just committed a cleanup commit to remove the import.
Additional fix for columns with cardinality 0
This reverts commit 142742f.
* Revert "Revert "add kinesis lag metric (apache#9509)" (#88)" This reverts commit 05fbcab. * refactor SeekableStreamSupervisor usage of RecordSupplier (apache#9819) * refactor SeekableStreamSupervisor usage of RecordSupplier to reduce contention between background threads and main thread, refactor KinesisRecordSupplier, refactor Kinesis lag metric collection and emitting * fix style and test * cleanup, refactor, javadocs, test * fixes * keep collecting current offsets and lag if unhealthy in background reporting thread * review stuffs * add comment
* imply-5135 Complete tests * Extended result of getTables based on team feedback * Refactored getRunning maps according to PR comments * Made tables API more consistent * Fix broken unit tests * Added Derby test * PR feedback
No description provided.