Refactor the indexing service to be able to better support realtime tasks #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 6, 2013 11:09
Conflicts: merger/src/test/java/com/metamx/druid/merger/coordinator/RemoteTaskRunnerTest.java server/src/main/java/com/metamx/druid/master/DruidMaster.java
Conflicts: merger/src/main/java/com/metamx/druid/merger/common/TaskStatus.java merger/src/main/java/com/metamx/druid/merger/common/task/DeleteTask.java merger/src/main/java/com/metamx/druid/merger/common/task/IndexDeterminePartitionsTask.java merger/src/main/java/com/metamx/druid/merger/common/task/Task.java merger/src/main/java/com/metamx/druid/merger/common/task/V8toV9UpgradeTask.java merger/src/main/java/com/metamx/druid/merger/coordinator/MergerDBCoordinator.java merger/src/main/java/com/metamx/druid/merger/coordinator/RemoteTaskRunner.java merger/src/test/java/com/metamx/druid/merger/coordinator/RemoteTaskRunnerTest.java
Conflicts: merger/src/main/java/com/metamx/druid/merger/common/TaskStatus.java merger/src/main/java/com/metamx/druid/merger/common/TaskToolbox.java merger/src/main/java/com/metamx/druid/merger/common/task/DeleteTask.java merger/src/main/java/com/metamx/druid/merger/common/task/IndexDeterminePartitionsTask.java merger/src/main/java/com/metamx/druid/merger/common/task/KillTask.java merger/src/main/java/com/metamx/druid/merger/common/task/Task.java merger/src/main/java/com/metamx/druid/merger/common/task/V8toV9UpgradeTask.java merger/src/main/java/com/metamx/druid/merger/coordinator/MergerDBCoordinator.java merger/src/main/java/com/metamx/druid/merger/coordinator/RemoteTaskRunner.java merger/src/main/java/com/metamx/druid/merger/coordinator/TaskMasterLifecycle.java merger/src/main/java/com/metamx/druid/merger/coordinator/TaskQueue.java merger/src/main/java/com/metamx/druid/merger/coordinator/TaskRunner.java merger/src/main/java/com/metamx/druid/merger/coordinator/TaskRunnerWorkQueue.java merger/src/main/java/com/metamx/druid/merger/coordinator/http/IndexerCoordinatorNode.java merger/src/main/java/com/metamx/druid/merger/coordinator/http/IndexerCoordinatorServletModule.java merger/src/test/java/com/metamx/druid/merger/coordinator/RemoteTaskRunnerTest.java
|
|
||
| public URI getServiceUri() throws URISyntaxException | ||
| { | ||
| return new URI("http://localhost:8087/mmx/merger/v1/action"); |
There was a problem hiding this comment.
The user is expected to edit /etc/hosts to point this name at the desired service.
There was a problem hiding this comment.
can you even override localhost from the hosts file?
| log.info("Task %s switched from pending to running", taskId); | ||
| } else { | ||
| // Nothing running this task, announce it in ZK for a worker to run it | ||
| zkWorker = findWorkerForTask(); |
There was a problem hiding this comment.
General comment about assigning work to workers. We only assign work to workers if their worker version is greater than some value we have specified in the DB config. This is something we decided about how to do rolling restarts. The autoscaling will see we lack workers of a specific version and create things. Tasks will get assigned to them and after awhile, old workers will have no tasks and auto scaling will terminate them. However, this also means we have to update the DB each time we update the indexer, which we will forget to do.
There was a problem hiding this comment.
If deploying a new indexer is equivalent to updating this version, then why will we forget?
Conflicts: merger/src/main/java/com/metamx/druid/merger/worker/config/WorkerConfig.java
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
May 5, 2020
* Fix potential NPEs in joins intelliJ reported issues with potential NPEs. This was first hit in testing with a filter being pushed down to the left hand table when joining against an indexed table. * More null check cleanup * Optimize filter value rewrite for IndexedTable * Add unit tests for LookupJoinable * Add tests for IndexedTableJoinable * Add non null assert for dimension selector * Supress null warning in LookupJoinMatcher * remove some null checks on hot path
abhishekagarwal87
referenced
this pull request
in abhishekagarwal87/druid
Dec 14, 2020
…d be) (#87) * leadership election was easier than i thought it would be * fix build * log retry failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces many changes on the indexing service to support real time tasks.