Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename d1/d2 column in tests #17471

Merged
merged 18 commits into from
Nov 22, 2024
Merged

Rename d1/d2 column in tests #17471

merged 18 commits into from
Nov 22, 2024

Conversation

kgyrtkirk
Copy link
Member

  • TestDataBuilder defines d1/d2 columns
  • DruidQuery could be affected by the presence of those columns - as they may interfere with the prefix selection
  • DruidCorrelateUnnestRule removes a project fully while it operates - which may cause all underlying columns to appear

Introduction of DruidRelFieldTrimmer which could remove unused columns under Correlate cause lots of _ differences between the decoupled and the old planner as DruidCorrelateUnnestRule essentially undoes the trimming

@kgyrtkirk kgyrtkirk marked this pull request as ready for review November 21, 2024 09:37
@kgyrtkirk kgyrtkirk merged commit 20aea29 into apache:master Nov 22, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants