Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark suite for MSQ window functions #17377

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Akshat-Jain
Copy link
Contributor

@Akshat-Jain Akshat-Jain commented Oct 18, 2024

Description

This PR adds a benchmark suite for MSQ window function queries.

A sample run on my local gave the following results:

Benchmark                                                         (maxNumTasks)  (rowsPerSegment)  Mode  Cnt      Score      Error  Units
MSQWindowFunctionsBenchmark.windowWithoutGroupBy                              2          20000000  avgt    5  96681.604 ± 2425.579  ms/op
MSQWindowFunctionsBenchmark.windowWithoutGroupBy                              5          20000000  avgt    5  94676.305 ± 4012.108  ms/op
MSQWindowFunctionsBenchmark.windowWithoutSorting                              2          20000000  avgt    5  17515.970 ±  498.066  ms/op
MSQWindowFunctionsBenchmark.windowWithoutSorting                              5          20000000  avgt    5  15996.262 ± 1552.218  ms/op
MSQWindowFunctionsBenchmark.multipleWindows                                   2          20000000  avgt    5   63215.499 ± 4722.604  ms/op
MSQWindowFunctionsBenchmark.multipleWindows                                   5          20000000  avgt    5   69287.847 ± 4985.326  ms/op
MSQWindowFunctionsBenchmark.windowWithHighCardinalityPartitionBy              2          20000000  avgt    5   69469.122 ± 3016.019  ms/op
MSQWindowFunctionsBenchmark.windowWithHighCardinalityPartitionBy              5          20000000  avgt    5   70951.896 ± 4343.354  ms/op
MSQWindowFunctionsBenchmark.windowWithLowCardinalityPartitionBy               2          20000000  avgt    5     507.584 ±  600.999  ms/op
MSQWindowFunctionsBenchmark.windowWithLowCardinalityPartitionBy               5          20000000  avgt    5     413.795 ±   38.195  ms/op
MSQWindowFunctionsBenchmark.windowWithSorting                                 2          20000000  avgt    5   16682.792 ±  239.561  ms/op
MSQWindowFunctionsBenchmark.windowWithSorting                                 5          20000000  avgt    5   16422.890 ±  225.643  ms/op

(Note: The above run was done with the changes of #17373, as otherwise I was running into the Channel has no capacity issue)


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - Querying Area - Dependencies Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Batch Ingestion Area - Dependencies Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant