Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with while adding DistinctSketches #17184

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix bug with while adding DistinctSketches #17184

merged 2 commits into from
Sep 30, 2024

Conversation

adarshsanjeev
Copy link
Contributor

Fix a bug where we incorrectly call retainedKeys.firstKey() twice while adding another sketch. This can sometimes throw an exception if there was only one key, and/or create an inaccurate estimate of the bytes retained.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Sep 30, 2024
@cryptoe cryptoe added this to the 31.0.0 milestone Sep 30, 2024
@cryptoe cryptoe merged commit 95fb813 into apache:master Sep 30, 2024
56 checks passed
adarshsanjeev added a commit to adarshsanjeev/druid that referenced this pull request Sep 30, 2024
@adarshsanjeev
Fix bug with while adding DistinctSketches (apache#17184)
b8b0e8a 
* Fix bug with checking the incorrect key

* Add tests
@adarshsanjeev adarshsanjeev mentioned this pull request Sep 30, 2024
Merged
abhishekagarwal87 pushed a commit that referenced this pull request Sep 30, 2024
@adarshsanjeev
Fix bug with while adding DistinctSketches (#17184) (#17189)
bd71a81 
* Fix bug with checking the incorrect key

* Add tests
@kfaraz kfaraz mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoe cryptoe cryptoe approved these changes

Assignees
No one assigned
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Bug
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adarshsanjeev @cryptoe