Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce logging in RetryableS3OutputStream #16853

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Reduce logging in RetryableS3OutputStream #16853

merged 3 commits into from
Aug 8, 2024

Conversation

Akshat-Jain
Copy link
Contributor

Description

This PR reduces logging in RetryableS3OutputStream.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@LakshSingla LakshSingla merged commit 7f67d26 into apache:master Aug 8, 2024
56 checks passed
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
@kfaraz kfaraz mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LakshSingla LakshSingla LakshSingla left review comments

@kfaraz kfaraz kfaraz left review comments

@cryptoe cryptoe cryptoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Akshat-Jain @cryptoe @kfaraz @LakshSingla