Add config for http client connect timeout #16831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdf2014
reviewed
Aug 5, 2024
| @@ -91,7 +91,7 @@ public HttpClient get() | |||
| httpClient.setIdleTimeout(config.getReadTimeout().getMillis()); | |||
| httpClient.setMaxConnectionsPerDestination(config.getNumConnections()); | |||
| httpClient.setMaxRequestsQueuedPerDestination(config.getNumRequestsQueued()); | |||
| httpClient.setConnectTimeout(CLIENT_CONNECT_TIMEOUT_MILLIS); | |||
| httpClient.setConnectTimeout(config.getClientConnectTimeout()); | |||
There was a problem hiding this comment.
It would be better to remove CLIENT_CONNECT_TIMEOUT_MILLIS variable as well
abhishekagarwal87
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a configuration
clientConnectTimeoutto our http client config which controls the connection timeout for our http client requests.It was observed that on busy K8S clusters, the default connect timeout of 500ms is sometimes not enough time to complete syn/acks for a request and in these cases, the requests timeout with the error:
exceptionType=java.net.SocketTimeoutException, exceptionMessage=Connect TimeoutThis behavior was mostly observed on the router while forwarding queries to the broker.
Having a slightly higher connect timeout helped resolve these issues.
####Release Note:
Adds http client config
clientConnectTimeoutto configure connection timeouts for Druid http client requests.This PR has: