serialize legacy as false for scan query for rolling downgrade/upgrade #16793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
reviewed
Jul 24, 2024
| @@ -443,6 +443,12 @@ public List<ColumnType> getColumnTypes() | |||
| return columnTypes; | |||
| } | |||
|
|
|||
| @JsonProperty("legacy") | |||
There was a problem hiding this comment.
Could use a javadoc and a @Deprecated annotation. Javadoc could be something like:
/**
* Prior to PR https://github.com/apache/druid/pull/16659 (Druid 31) data servers require
* the "legacy" parameter to be set to a non-null value. For compatibility with older data
* servers during rolling updates, we need to write out "false".
*/
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .dataSource("source") | ||
| .intervals(intervalSpec) | ||
| .build(); | ||
| Assert.assertFalse(query.isLegacy()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
clintropolis
changed the title
abhishekagarwal87
approved these changes
Jul 25, 2024
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
apache#16793) Fixes rolling downgrades/upgrades after apache#16659 by hard coding scan query "legacy":false since it is a required property during deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rolling downgrades/upgrades after #16659 by hard coding scan query
"legacy":falsesince it is a required property during deserialization.