Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for Unsupported Aggregation with Distinct when useApproxCountDistinct is enabled #16770

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Check for Unsupported Aggregation with Distinct when useApproxCountDistinct is enabled #16770

merged 9 commits into from
Jul 24, 2024

Conversation

sreemanamala
Copy link
Contributor

Description

Checks and throws an actionable error in case we encounter any aggregator using distinct which does not support it as mentioned in this issue

Key changed/added classes in this PR
  • NativelySupportsDistinct
  • DruidSqlValidator
  • GroupByRules

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@asdf2014 asdf2014 merged commit 3f4d66c into apache:master Jul 24, 2024
88 checks passed
@sreemanamala sreemanamala deleted the approx-count branch July 24, 2024 04:20
@gianm gianm mentioned this pull request Jul 24, 2024
Open
sreemanamala added a commit to sreemanamala/druid that referenced this pull request Aug 6, 2024
@sreemanamala @asdf2014
Check for Unsupported Aggregation with Distinct when useApproxCountDi…
13f249b 
…stinct is enabled (apache#16770)

* init

* add NativelySupportsDistinct

* refactor

* javadoc

* refactor

* fix tests

* fix drill tests

* comments

* Update sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java

---------

Co-authored-by: Benedict Jin <[email protected]>
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
@kfaraz kfaraz mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdf2014 asdf2014 asdf2014 approved these changes

@kgyrtkirk kgyrtkirk kgyrtkirk approved these changes

Assignees
No one assigned
Labels
Area - Querying
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sreemanamala @kgyrtkirk @asdf2014 @kfaraz