Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WINDOW_LEAF_OPERATOR for native engine to support queries without group by #16753

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

sreemanamala
Copy link
Contributor

Description

This commit is to temporarily fix the issues with window queries without a group by clause, by setting the leaf operator to empty instead of null so as to stop the planner to rewrite the query assigning a leaf operator.
Once the Wire Transferable interface is fixed, we can disable this.


Key changed/added classes in this PR
  • NativeSqlEngine

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kgyrtkirk kgyrtkirk merged commit c9aae9d into apache:master Jul 22, 2024
88 checks passed
sreemanamala added a commit to sreemanamala/druid that referenced this pull request Aug 6, 2024
@sreemanamala sreemanamala deleted the eat-leaf-op branch September 18, 2024 11:24
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants