Throw exceptions in SqlValidator when DISTINCT used over WINDOW #16738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
reviewed
Jul 16, 2024
...src/test/java/org/apache/druid/query/aggregation/variance/sql/VarianceSqlAggregatorTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/druid/query/aggregation/variance/sql/VarianceSqlAggregatorTest.java
Show resolved
Hide resolved
kgyrtkirk
approved these changes
Jul 18, 2024
kgyrtkirk
reviewed
Jul 19, 2024
Comment on lines
215
to
220
| if (rows.size() == numRows()) { | ||
| extraColumns.put(name, column); | ||
| columnNames.add(name); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
instead of removing it entirely - possibly a check would be nice to ensure that only columns which ColumnValueSwapper gets added like that.
There was a problem hiding this comment.
made it check for instances of ObjectArrayColumn
kgyrtkirk
reviewed
Jul 22, 2024
processing/src/main/java/org/apache/druid/query/rowsandcols/ArrayListRowsAndColumns.java
Outdated
Show resolved
Hide resolved
sreemanamala
added a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
…he#16738) * Throw exception if DISTINCT used with window functions aggregate call * Improve error message when unsupported aggregations are used with window functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Key changed/added classes in this PR
DruidSqlValidatorWindowingThis PR has: