Window Function offset correction for RAC #16718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
reviewed
Jul 11, 2024
Comment on lines
-13
to
-15
| 'k(1)', | ||
| COUNT(1) OVER (ORDER BY FLOOR(m1/3) ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING), | ||
| COUNT(1) OVER (ORDER BY FLOOR(m1/3) RANGE BETWEEN 1 PRECEDING AND 1 FOLLOWING) |
There was a problem hiding this comment.
why remove this test; and not just these?
There was a problem hiding this comment.
yeah, make sense to just remove these 1 PRECEDING AND 1 FOLLOWING. Later on when we start supporting them, we can modify this test to keep the comparisons between ROWS and RANGE in different scenarios at one place. will update it. Thanks for the review @kgyrtkirk !!
kgyrtkirk
approved these changes
Jul 15, 2024
sreemanamala
added a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
* When an ArrayList RAC creates a child RAC, the start and end offsets need to have the offset of parent's start offset * Defaults the 2nd window bound to CURRENT ROW when only a single bound is specified * Removes the windowingStrictValidation warning and throws a hard exception when Order By alongside RANGE clause is not provided with UNBOUNDED or CURRENT ROW as both bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes in this commit :
windowingStrictValidationwarning and throws a hard exception when Order By alongside RANGE clause is not provided with UNBOUNDED or CURRENT ROW as both boundsKey changed/added classes in this PR
DruidSqlValidatorArrayListRowsAndColumnsThis PR has: