Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for sketches on workers #16697

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

adarshsanjeev
Copy link
Contributor

Small PR to improve the logging of sketches on workers.

This function is already called on the controller to print information regarding the most downsampled sketches. This should give more information on the sketches being downsampled at a worker level.

@github-actions github-actions bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Jul 7, 2024
Copy link
Contributor

@LakshSingla LakshSingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controller should also rely on the logSketches() method to explicitly log the sketches. Currently, it's done implicitly in generatePartitionsWithTargetWeight and generatePartitionsWithMaxCount.

@LakshSingla LakshSingla merged commit 7c62535 into apache:master Jul 9, 2024
54 checks passed
@LakshSingla
Copy link
Contributor

Thanks for the patch!

sreemanamala pushed a commit to sreemanamala/druid that referenced this pull request Aug 6, 2024
Improve the logging of sketches on workers.
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants