Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a segmentMorphFactory to MSQ Datasource Destination #16692

Closed
wants to merge 12 commits into from

Conversation

adarshsanjeev
Copy link
Contributor

Description

Introduces the concept of segmentMorphFactory to DataSourceMSQDestination and refactors some of the existing code around frames and semantic utils.
A segmentMorphFactory is a way to introduce an alternate final stage during ingestion with MSQ. This opens up the possibility of modifying segments instead of generating new segments as a result of the query.

This PR should not have a functional impact, and is meant to be used for other features in the future.

Major changes include:

  • Refactor SemanticCreator and add SemanticUtils.
  • Add a segmentMorphFactory FrameProcessorFactory to MSQ.
  • Refactor SimpleQueryableIndex to take a metadata supplier. Refactor TmpFileSegmentWriteOutMedium to use a heap based WriteOutBytes before falling back to a temporary file.
  • Add FieldReader#makeRACColumn for use with row based frames.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - Querying Area - Segment Format and Ser/De Area - Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Jul 4, 2024
@adarshsanjeev
Copy link
Contributor Author

Will break this up into smaller PRs for reviewability

@adarshsanjeev
Copy link
Contributor Author

Created these PRs:
#16698
#16699
#16700
#16707
#16708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants