Fix flaky test in RetryableS3OutputStreamTest #16639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #16481, we have started uploading the chunks in parallel. That means that it's not necessary for the
part that was uploaded at the last
to be less than or equal to thechunkSize
(as the final part could've been uploaded earlier).This made a test in RetryableS3OutputStreamTest flaky where we were asserting that the final part should be smaller than chunk size.
This PR fixes the test, and also adds another test where the file size is such that all chunk sizes would be of equal size.
This PR has: