Fix serde for ArrayOfDoublesSketchConstantPostAggregator. #16550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version originally added in apache#13819 was missing an annotation for the "value" property. Fixes apache#16539. Line endings for ArrayOfDoublesSketchConstantPostAggregator.java are changed from \r\n to \n. Adds a serde test, and improves various other datasketches post-aggregator serde tests to deserialize into PostAggregator. This verifies that the type information is set up correctly.
cryptoe
approved these changes
Jun 5, 2024
kgyrtkirk
approved these changes
Jun 5, 2024
Comment on lines
+79
to
+82
| PostAggregator andBackAgain = mapper.readValue( | ||
| mapper.writeValueAsString(there), | ||
| PostAggregator.class | ||
| ); |
There was a problem hiding this comment.
its stunning to see that this was not caught earlier - I wonder if exercising the serde-s in the Calcite*Test classes might make these issues surface
...another possible way could be to ensure that annotations inside the classes are consistent - but I guess that can't be enforced for all classes as custom serializers might also be
we'll keep these in mind :)
There was a problem hiding this comment.
Perhaps we could use some approach like EqualsVerifier. Whatever magic it does to verify equals and hashCode could possible be used to verify serde as well? I never looked inside it to see what it's doing.
asdf2014
approved these changes
Jun 5, 2024
...va/org/apache/druid/query/aggregation/datasketches/hll/HllSketchUnionPostAggregatorTest.java
Outdated
Show resolved
Hide resolved
asdf2014
reviewed
Jun 5, 2024
...che/druid/query/aggregation/datasketches/quantiles/DoublesSketchToCDFPostAggregatorTest.java
Outdated
Show resolved
Hide resolved
...uid/query/aggregation/datasketches/quantiles/DoublesSketchToHistogramPostAggregatorTest.java
Outdated
Show resolved
Hide resolved
...ruid/query/aggregation/datasketches/quantiles/DoublesSketchToQuantilePostAggregatorTest.java
Outdated
Show resolved
Hide resolved
...uid/query/aggregation/datasketches/quantiles/DoublesSketchToQuantilesPostAggregatorTest.java
Outdated
Show resolved
Hide resolved
...he/druid/query/aggregation/datasketches/quantiles/DoublesSketchToRankPostAggregatorTest.java
Outdated
Show resolved
Hide resolved
.../druid/query/aggregation/datasketches/quantiles/DoublesSketchToStringPostAggregatorTest.java
Outdated
Show resolved
Hide resolved
...ache/druid/query/aggregation/datasketches/kll/KllFloatsSketchToStringPostAggregatorTest.java
Outdated
Show resolved
Hide resolved
|
Fixed the excessive imports. Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version originally added in #13819 was missing an annotation for the "value" property. Fixes #16539.
Line endings for ArrayOfDoublesSketchConstantPostAggregator.java are changed from
\r\nto\n. Try viewing with whitespace ignored to make the diff easier to read. The really meaningful change is adding a single line.Adds a serde test, and improves various other datasketches post-aggregator serde tests to deserialize into PostAggregator. This verifies that the type information is set up correctly.