Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove references to Zk-based segment loading #16360

Merged
merged 1 commit into from
May 1, 2024

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Apr 30, 2024

Follow up to #15705

Changes:

  • Remove references to ZK-based segment loading in the docs
  • Fix doc for existing config druid.coordinator.loadqueuepeon.http.repeatDelay

Copy link
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kfaraz!


`druid.zk.service.enabled=false`
`druid.serverview.type=http`
`druid.coordinator.loadqueuepeon.type=http`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more reference in integration-tests/k8s/tiny-cluster.yaml: druid.coordinator.loadqueuepeon.type=http which can also be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @abhishekrb19 . There are a couple more references in the code that I plan to tackle in a separate PR. Keeping this one only for the docs changes.

@kfaraz kfaraz merged commit 51104e8 into apache:master May 1, 2024
8 checks passed
@kfaraz kfaraz deleted the doc_remove_zk_peon branch May 1, 2024 02:36
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants