Fix defaults of segment schema cleanup #16354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for updating it @kfaraz. LGTM! |
findingrish
approved these changes
Apr 30, 2024
kgyrtkirk
approved these changes
Apr 30, 2024
|
Thanks for the review, @findingrish , @kgyrtkirk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to align with the default values of segment schema cleanup used in #15705 .
The current values of
period = 1 hour,durationToRetain = 6 hoursis too aggressive.All other metadata cleanup configs use
period = 1 day,durationToRetain = 90 days.