Include exception message in errorMessage for failed task #16286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
reviewed
Apr 15, 2024
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java
Outdated
Show resolved
Hide resolved
…ord/TaskQueue.java Co-authored-by: Kashif Faraz <[email protected]>
|
@YongGang , |
kfaraz
reviewed
Apr 16, 2024
| + "See overlord logs for more details."; | ||
| errorMessage = StringUtils.format( | ||
| "Encountered error[%s] while waiting for task to be ready. See Overlord logs for more details.", | ||
| e.getMessage() |
There was a problem hiding this comment.
It would also be a good idea to trim this message if it exceeds a certain length.
There was a problem hiding this comment.
Thanks Kashif, updated the code.
There was a problem hiding this comment.
We should be chopping only the contents of e.getMessage(). Chopping out the parts while waiting for task to be ready. See Overlord logs for more details. would be less user friendly.
There was a problem hiding this comment.
Suggested change
| e.getMessage() | |
| StringUtils.chop(e.getMessage(), 100) |
kfaraz
approved these changes
Apr 18, 2024
| @@ -314,7 +315,7 @@ public boolean isReady(TaskActionClient taskActionClient) | |||
| Assert.assertEquals(TaskState.FAILED, statusOptional.get().getStatusCode()); | |||
| Assert.assertNotNull(statusOptional.get().getErrorMsg()); | |||
| Assert.assertTrue( | |||
| statusOptional.get().getErrorMsg().startsWith("Failed while waiting for the task to be ready to run") | |||
| statusOptional.get().getErrorMsg().contains(exceptionMsg) | |||
There was a problem hiding this comment.
Nit: Better to verify the whole error message rather than contains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following is an example of auto-compaction subtask failure we can see from task Status field in Druid console.
Now include the actual exception message in the task Status output to easily understand the failure instead of having to check from Overlord logs.
Key changed/added classes in this PR
TaskQueue.javaadd exception message to errorMessageThis PR has: