Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog table should not need explicit segment granularity set #16278

Merged
merged 19 commits into from
Apr 17, 2024

Conversation

zachjsh
Copy link
Contributor

@zachjsh zachjsh commented Apr 12, 2024

Description

This change allows catalog tables to be defined without explicit segment granularities defined. DML queries on such tables will either need to have the PARTITIONED BY clause specified, or the table will need to be updated to include a defined segment granularity for DML queries to be validated properly. This PR is built on top of #16223, so that change should be merged first

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@zachjsh zachjsh merged commit 3f2dd46 into apache:master Apr 17, 2024
85 checks passed
@zachjsh zachjsh deleted the catalog-table-no-segment-gran-needed branch April 17, 2024 15:46
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants