Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the aggregation value based on final compute #16244

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

sreemanamala
Copy link
Contributor

Description

This PR tries to fix the aggregated result in the window frame by invoking the finalize computation of corresponding aggregator factory prior to storing the result.


Key changed/added classes in this PR
  • DefaultFramedOnHeapAggregatable.java

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kgyrtkirk kgyrtkirk merged commit f65c166 into apache:master Apr 12, 2024
85 checks passed
@sreemanamala sreemanamala deleted the frame-agg branch April 12, 2024 07:40
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants