Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: don't send lookups to sampler #16234

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

vogievetsky
Copy link
Contributor

@vogievetsky vogievetsky commented Apr 3, 2024

Instead of sending transform expressions containing lookups to the sampler, which is guaranteed to give an error of lookup not found due to lookups not being loaded on the overlord, change the transform to a placeholder so it does not block the flow:

image

image

image

@vogievetsky vogievetsky merged commit 3ba878f into master Apr 5, 2024
12 checks passed
@vogievetsky vogievetsky deleted the dont-send-lookups-to-sampler branch April 5, 2024 04:17
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants