Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling an empty list of versions #16198

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Fix handling an empty list of versions #16198

merged 3 commits into from
Mar 26, 2024

Commits on Mar 25, 2024

  1. Differentiate null and empty lists of segment IDs and versions. 

    Treat them differently so the. Segment IDs and versions can be An empty list,
in which case, the queries should just not return anything. Versions are optional, so
they can be null, which just indicates nothing, so the queries should return segments with
all possible versions. Segment IDs cannot be null as indicated by the absence of @nullable
annotation.
    @abhishekrb19
    abhishekrb19 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    cbf9849 View commit details
    Browse the repository at this point in the history

  2. Update javadocs and add empty versions test to kill task.

    @abhishekrb19
    abhishekrb19 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ff69ede View commit details
    Browse the repository at this point in the history

  3. Add test for RetrieveSegmentsActions as well.

    @abhishekrb19
    abhishekrb19 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    424b6b5 View commit details
    Browse the repository at this point in the history