Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric emission in the segment generation phase #16146

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

abhishekagarwal87
Copy link
Contributor

Replace the usage of RealTimeMetricsMonitor with TaskRealTimeMetricsMonitor that also emits RowIngestionMeters. Before this change, the tasks did not emit metrics such as processed events.

Copy link
Contributor

@AmatyaAvadhanula AmatyaAvadhanula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AmatyaAvadhanula AmatyaAvadhanula merged commit 7d307df into apache:master Mar 18, 2024
84 checks passed
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants