-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for 29.0.1 patch release #15960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/release-info/release-notes.md
Outdated
* Added type verification for INSERT and REPLACE to validate that strings and string arrays aren't mixed [#15920](https://github.com/apache/druid/pull/15920) | ||
* Fixed an issue where the Druid web console generates a Kafka supervisor spec where `flattenSpec` is in the wrong place, causing it to be ignored [#15946](https://github.com/apache/druid/pull/15946) | ||
* Fixed an issue with filters on expression virtual column indexes incorrectly considering values null in some cases for expressions which translate null values into not null values [#15959](https://github.com/apache/druid/pull/15959) | ||
* Fixed an issue where the `arrayIngestMode` value can persist across the SQL tab in the **Query** console, even if you execute unrelated DML operations within the same tab [#15927](https://github.com/apache/druid/pull/15927) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description it not quite correct. All query context parameters are persisted until you clear them. This fix simply makes the console only set the context parameter arrayIngestMode: array
if NEEDED (before it will set it on every generated query as a "nice to have"). So at best this change mitigates the issue, does not fix it.
But that is ok since the type verification for INSERT and REPLACE
(2nd point above) change actually fixes the issue that would have gotten you into trouble.
The description here should read:
* Web console generated queries will only set the context parameter `arrayIngestMode` to `array` when the user explicitly opts in to use arrays [#15927](https://github.com/apache/druid/pull/15927)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the information. I've updated the note.
|
||
* Added type verification for INSERT and REPLACE to validate that strings and string arrays aren't mixed [#15920](https://github.com/apache/druid/pull/15920) | ||
* [Concurrent replace](https://druid.apache.org/docs/latest/ingestion/concurrent-append-replace) now allows pending Peon segments to be upgraded using the Supervisor [#15995](https://github.com/apache/druid/pull/15995) | ||
* Changed the `targetDataSource` attribute to return a string containing the name of the datasource. This reverts the breaking change introduced in Druid 29.0.0 for INSERT and REPLACE MSQ queries [#16004](https://github.com/apache/druid/pull/16004) [#16031](https://github.com/apache/druid/pull/16031) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ektravel this line should go in the upgrade notes too cause it's an incompatible change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@317brian upgrade-notes.md on the master branch, correct?
This PR adds release notes for the 29.0.1 release.
This PR has: