Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the link of Helm Chart to avoid 404 error #15905

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

asdf2014
Copy link
Member

Description

Because a new code repository has been created to maintain the Helm Chart for Apache Druid, the links inside the README have been updated to avoid 404 error. We can merge this after #15904


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@abhishekagarwal87
Copy link
Contributor

How about leaving a note in docs that point to your repo? So someone searching for helm charts could at least find the charts in your repo.

@asdf2014
Copy link
Member Author

@abhishekagarwal87 Yes, that'll be great. Please feel free to raise another PR to add note in docs, meanwhile let's focus on updating the links here, how does that sound to you 😄

@abhishekagarwal87
Copy link
Contributor

Why not do it in this PR itself? :)

@asdf2014 asdf2014 changed the title Update the link of Helm Chart Update the link of Helm Chart to avoid 404 error Feb 21, 2024
@asdf2014
Copy link
Member Author

@abhishekagarwal87 I think we should ensure that the content of the PR closely aligns with the theme as much as possible. Content with weaker relevance can be included in subsequent PRs, making it easier to review the code. :)

Copy link
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the link first

@asdf2014 asdf2014 merged commit 0f38a98 into master Feb 21, 2024
7 checks passed
@asdf2014 asdf2014 deleted the update_helm_link branch February 21, 2024 08:57
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants