-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Union in decoupled mode #15870
Merged
Merged
Changes from 79 commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
ecd7099
Support Window operators in decoupled planning
kgyrtkirk 37d11f3
no more need for workaround that `getTrait(T)` sometimes returns RelC…
kgyrtkirk ce3bd03
lets not do this now
kgyrtkirk 8112d1d
describe stuff
kgyrtkirk 5a1b740
add
kgyrtkirk 274fbfa
add test to remove modes
kgyrtkirk 443058b
some stuff
kgyrtkirk 0ba43ac
add fixme
kgyrtkirk 0c132df
some unrelated
kgyrtkirk aec32da
Revert "some unrelated"
kgyrtkirk d1b2dad
some stuff
kgyrtkirk 2dd63ab
a different approach
kgyrtkirk a8e04db
remove stuff
kgyrtkirk 7657e7d
cleanup
kgyrtkirk 9775c1a
temp-crap
kgyrtkirk 6e6c752
talk
kgyrtkirk 407d4f3
Revert "talk"
kgyrtkirk c9dbe26
cleanup
kgyrtkirk ef01196
cleanup
kgyrtkirk 1ebe421
fix/etc union
kgyrtkirk a83dd8d
updates
kgyrtkirk 7a94653
cleanup
kgyrtkirk 4f78e85
move org.reflections to depManagement
kgyrtkirk 6e9e5ee
checkstyle
kgyrtkirk 3bc9326
cleanup
kgyrtkirk 7ff59fc
merge 2 enum entries
kgyrtkirk fd858b5
Merge remote-tracking branch 'apache/master' into decouple-support-wi…
kgyrtkirk df615e0
Merge branch 'decouple-support-window2' into decouple-support-union
kgyrtkirk cab8b8f
xinputprod
kgyrtkirk 646559e
partially undo
kgyrtkirk aea1021
add interface
kgyrtkirk 11c1d30
PDQVertexFactoy
kgyrtkirk 04e6712
move pdqfactory to new file
kgyrtkirk 8d363b2
move class
kgyrtkirk 58d5344
rename/etc
kgyrtkirk 9d2a061
extract common
kgyrtkirk 2cce30e
move stuff around
kgyrtkirk 84326a2
some stuff
kgyrtkirk 56dd715
remove project field
kgyrtkirk 2522d50
set druidTable for now
kgyrtkirk 15c9e79
fix currentTable for scan
kgyrtkirk e333267
values
kgyrtkirk e9198b7
remove
kgyrtkirk 40c02e2
cleanup
kgyrtkirk 712191a
remove cTSCBV
kgyrtkirk e240bbf
format/etc
kgyrtkirk 08235d9
format
kgyrtkirk 19d455d
cleanup
kgyrtkirk 2a723f1
rename
kgyrtkirk d50a491
rename/etc
kgyrtkirk 03daf53
cleanup
kgyrtkirk 71a2d18
make vertex/pdqvertexfactory an inner class
kgyrtkirk 7ac5327
retire some createVertex methods
kgyrtkirk 1ba7958
supller/etc
kgyrtkirk a9b9cf8
undo supplier
kgyrtkirk 7694d6f
order interface methods
kgyrtkirk 6cb2846
cleanup
kgyrtkirk 00264db
refactor
kgyrtkirk c33122f
format
kgyrtkirk 46c6299
cleanup
kgyrtkirk 587de39
wiggle
kgyrtkirk 9177573
cleanup
kgyrtkirk 9690ae3
cleanup
kgyrtkirk 6f678b4
cleanup
kgyrtkirk a18726b
add some apidoc
kgyrtkirk 797e806
raise class security a bit
kgyrtkirk 7bf90e5
fix err
kgyrtkirk b0d5f9e
fix bug
kgyrtkirk 63630e3
remove debug on by default
kgyrtkirk 4600378
remove processUnion method
kgyrtkirk 84048a2
cleanup
kgyrtkirk c0307fa
add test
kgyrtkirk e3e9379
enable test for CalciteUnionQueryTest
kgyrtkirk 87c345b
rename method
kgyrtkirk 87f801c
change message
kgyrtkirk a7e04e2
update
kgyrtkirk 7770e37
cleanup
kgyrtkirk 3d5dcd7
fix
kgyrtkirk a7a1358
fix java8
kgyrtkirk 65f2d1a
tries with reflections
kgyrtkirk 98adcd0
restrict to org.apache.druid.sql
kgyrtkirk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the name of the method is no longer accurate (it's going beyond
baseRuleSet
). It appears this is only used in decoupled mode-- is that correct? If so some comments about that, or reflecting it in the name, would be useful.Haven't read the rest of the patch as yet, so this is just a single comment rather than a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to separate basic optimiazation rules from the conversion rules - it will be usefull to be able to enable/tweak rules without altering the other planning rules.
It kinda already made one things easier: I was able to just throw in
UNION_MERGE
- without having to worry about disturbing existing plan differences.there will be some more deeper tweaking will be needed as
AGGREGATE_REMOVE
andAGGREGATE_CASE_TO_FILTER
doesn't play nicely together - which induces some plan differencesI can rename it to
buildDecoupledLogicalOptimizationProgram
- does that sound better?