Strict window frame checks #15746
Merged
Strict window frame checks #15746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* introduce check to ensure that window frame is supported * currently RANGE frames are only supported correctly if both endpoints are unbounded or current row * add `windowingStrictValidation` context key to provide a way to override the check
|
fyi: @317brian we need to document this context flag. |
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
Outdated
Show resolved
Hide resolved
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java
Outdated
Show resolved
Hide resolved
|
Can we put some more context in the description as to what the issue with range we are facing and also a github issue with what needs to be fix in the long run so that we can retire this custom query context when the time comes |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java
Fixed
Show fixed
Hide fixed
10 tasks
kgyrtkirk
added a commit
to kgyrtkirk/druid
that referenced
this pull request
Feb 2, 2024
introduce checks to ensure that window frame is supported added check to ensure that no expressions are set as bounds added logic to detect following/following like cases - described in Window function fails to demarcate if 2 following are used apache#15739 currently RANGE frames are only supported correctly if both endpoints are unbounded or current row Offset based window range support apache#15767 added windowingStrictValidation context key to provide a way to override the check (cherry picked from commit 8f5b752)
This was referenced Feb 2, 2024
kgyrtkirk
added a commit
to kgyrtkirk/druid
that referenced
this pull request
Feb 2, 2024
introduce checks to ensure that window frame is supported added check to ensure that no expressions are set as bounds added logic to detect following/following like cases - described in Window function fails to demarcate if 2 following are used apache#15739 currently RANGE frames are only supported correctly if both endpoints are unbounded or current row Offset based window range support apache#15767 added windowingStrictValidation context key to provide a way to override the check (cherry picked from commit 8f5b752)
abhishekagarwal87
pushed a commit
that referenced
this pull request
Feb 5, 2024
introduce checks to ensure that window frame is supported added check to ensure that no expressions are set as bounds added logic to detect following/following like cases - described in Window function fails to demarcate if 2 following are used #15739 currently RANGE frames are only supported correctly if both endpoints are unbounded or current row Offset based window range support #15767 added windowingStrictValidation context key to provide a way to override the check (cherry picked from commit 8f5b752)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windowingStrictValidationcontext key to provide a way to override the checkDescription
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: