Fix NullFilter getDimensionRangeSet. #15500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't checking the column name, so it would return a domain regardless of the input column. This means that null filters on datasources with range partitioning would lead to excessive pruning of segments, and therefore missing results.
clintropolis
approved these changes
Dec 6, 2023
pranavbhole
approved these changes
Dec 6, 2023
LakshSingla
pushed a commit
to LakshSingla/druid
that referenced
this pull request
Dec 7, 2023
It wasn't checking the column name, so it would return a domain regardless of the input column. This means that null filters on data sources with range partitioning would lead to excessive pruning of segments, and therefore missing results.
vogievetsky
pushed a commit
that referenced
this pull request
Dec 7, 2023
It wasn't checking the column name, so it would return a domain regardless of the input column. This means that null filters on data sources with range partitioning would lead to excessive pruning of segments, and therefore missing results. Co-authored-by: Gian Merlino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't checking the column name, so it would return a domain regardless of the input column. This means that null filters on datasources with range partitioning could lead to excessive pruning of segments, and therefore missing results.
The null filter was introduced in #14542, meaning this query correctness bug has existed since 27.0. It will likely be more commonly hit in 28.0 because the null handling mode is on by default (and therefore this filter is generated by SQL planning by default) since #14792.