-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MSQ Durable Storage Connector for Google Cloud Storage and change current Google Cloud Storage client library #15398
Merged
cryptoe
merged 30 commits into
apache:master
from
gargvishesh:35053-gcs-durable-storage-connector
Dec 14, 2023
Merged
Changes from 25 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f40e285
Initial commit with the new GCS library
gargvishesh b4e719a
Changes for GCS Storage Connector
gargvishesh 09fef50
Remove exception
gargvishesh 10bad2f
Add prefix to paths
gargvishesh 9211a69
Fixes
gargvishesh 9a6ab03
Working version with fixes for removing try-with-resource and objectP…
gargvishesh 546b1ef
Minor changes
gargvishesh 26be863
Use full path for deleteRecursively and fix tests
gargvishesh 937056b
Refactoring and checkstyle fixes
gargvishesh a166099
Doc updates
gargvishesh a84a368
Remove GCS BOM in dependency management
gargvishesh 1e8b38f
Remove comments
gargvishesh 8319d4c
Create temp dir in google storage connector contructor
gargvishesh dad4289
Address review comments
gargvishesh b0d15be
Limit internal buffer size of GCS storage reader and writer channels
gargvishesh f9105a9
Update write buffer size to 2 MB
gargvishesh c05a9c0
Add GoogleStorageConnectorTest
gargvishesh 93a6df3
Merge branch 'master' into 35053-gcs-durable-storage-connector
gargvishesh 55febef
Address review comments
gargvishesh f09c461
Remove exception handling
gargvishesh 44e9b10
Fix exceptions and handling
gargvishesh 4454afb
Fix exceptions and handling - part 2
gargvishesh 9f30fd2
Fix exceptions and handling - part 3
gargvishesh fc51307
Fix build errors and pom
gargvishesh 54a9687
Add licenses and tests
gargvishesh 306d71a
fix license.yaml module name
gargvishesh 3bd3125
Add toString to GoogleInputRange
gargvishesh cb38ccd
Add GoogleStorageTest
gargvishesh 8294a33
Fix forbidden api error
gargvishesh 9e08c84
Fix forbidden api error - part 2
gargvishesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to update :
druid/integration-tests-ex/cases/pom.xml
Lines 154 to 164 in 8812495
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed now.