Remove deprecated coordinator dynamic configs #14923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove config
decommissioningMaxPercentOfMaxSegmentsToMove
smartSegmentLoading
(enabled by default)Remove config
maxNonPrimaryReplicantsToLoad
This was added in #11135 to address two requirements:
Both of these requirements are now already met thanks to:
replicationThrottleLimit
: ThereplicationThrottleLimit
now ensures that for any tier, the sum of the number of replicas in load queue at start of a coordinator run and the number of replicas assigned during the run is always within the limit. So, it can perform the same function asmaxNonPrimaryReplicantsToLoad
exceptreplicationThrottleLimit
is per tier.smartSegmentLoading
(enabled by default) takes care of all of the above without requiring the user to change any configPending
Release note
Remove deprecated coordinator dynamic configs:
decommissioningMaxPercentOfMaxSegmentsToMove
maxNonPrimaryReplicantsToLoad
These configs are not needed anymore as
smartSegmentLoading
automatically ensures the optimal behaviour in the underlying scenarios.This PR has: