Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up after add kill bufferPeriod #14868

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Aug 18, 2023

Follow up PR to #12599

That PR introduces some changes that can be simplified.

Changes

  • Rename column used_flag_last_updated to used_status_last_updated
  • Remove new CLI tool UpdateTables.
    • We already have a CreateTables with similar functionality, which should be able to handle update cases too.
    • Any user running the cluster for the first time should either just have druid.metadata.storage.connector.createTables enabled or run CreateTables which should create tables at the latest version.
    • For instance, the UpdateTables tool would be inadequate when a new metadata table has been added to Druid, and users would have to run CreateTables anyway.
  • Remove upgrade-prep.md and include that info in metadata-init.md.
  • Fix log messages to adhere to Druid style
  • Use lambdas

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz requested a review from jon-wei August 18, 2023 03:27
@kfaraz kfaraz changed the title Remove extra changes, rename column Clean up after add kill bufferPeriod Aug 18, 2023
Copy link
Contributor

@jon-wei jon-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfaraz
Copy link
Contributor Author

kfaraz commented Aug 18, 2023

Thanks for the review, @jon-wei !
Merging as failure in ITNestedQueryPushDownTest is unrelated.

@kfaraz kfaraz merged commit 097b645 into apache:master Aug 18, 2023
73 of 74 checks passed
@kfaraz kfaraz deleted the follow_up_kill_buffer branch August 18, 2023 18:30
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants