add context flag "useAutoColumnSchemas" to use new auto types for MSQ segment generation #14175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoe
approved these changes
Apr 27, 2023
| @@ -213,6 +215,11 @@ public static IndexSpec getIndexSpec(final QueryContext queryContext, final Obje | |||
| return decodeIndexSpec(queryContext.get(CTX_INDEX_SPEC), objectMapper); | |||
| } | |||
|
|
|||
| public static boolean useAutoColumnSchemas(final QueryContext queryContext) | |||
There was a problem hiding this comment.
Please document the use of this externally undocumented feature in the class level docs. https://github.com/apache/druid/pull/14175/files#diff-cbcc2f2c9d571876786fe63eef35c2d82d64de0700334267c22f83f31d633af0L51
cryptoe
added
the
Area - MSQ
clintropolis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new MSQ query context parameter
useAutoColumnSchemasas a sort of hacky backdoor to allow using the latest and greatest features added in #14014 and related PRs (#13803, etc). When set, all columns except for customCOMPLEXcolumn types will use the native 'auto' column indexer added in #14014 when generating segments. I call this a bit hacky because MSQ doesn't officially support the true array types besidesARRAY<STRING>, which is translated intoSTRINGunless the new context flag is set, but other array types can be still be ingested by specifyingCOMPLEX<json>as the input schema to use the complex passthrough.I did not document this at this time on purpose, this is mainly for allowing experimentation with the newer column features and MSQ.
This PR has: