Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add metrics port exposure via service and Prometheus ServiceMonitors #13991

Closed

Conversation

jwitko
Copy link
Contributor

@jwitko jwitko commented Mar 28, 2023

Fixes #13990.

Description

This PR provides a way to easy way to expose a configured metrics port via the existing services and also optionally generate ServiceMonitor resources for users leveraging Prometheus.

Release note

Add metrics port exposure via services and optional Prometheus ServiceMonitors to helm chart

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@abhishekagarwal87
Copy link
Contributor

I will take a look soon.

Copy link

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the [email protected] list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 10, 2024
@hfinucane
Copy link

This would still be a good idea.

@github-actions github-actions bot removed the stale label Feb 11, 2024
@asdf2014 asdf2014 added the Helm Chart https://github.com/apache/druid/tree/master/helm/druid label Feb 14, 2024
@asdf2014
Copy link
Member

@jwitko Thanks for your contribution. As mentioned in PR #15904, we have migrated the Helm Chart to a new repository, you are welcome to raise up new PR there and we can maintain the Druid Helm Chart together in new repository. And this PR will closed soon. Thank you again for your understanding and collaboration.

Copy link

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the [email protected] list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 22, 2024
Copy link

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Helm Chart https://github.com/apache/druid/tree/master/helm/druid stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart has no way to expose metrics once emitter is enabled
4 participants